pagure

#3590 Fix force logout button by making it form submit to be able to send post request
Merged by cverna. Opened by bkabrda.
bkabrda/pagure force-logout-post-fix  into  master

Download 3590.patch

TBH I'm not sure how to write a unit test for this, I think this could effectively be only tested by something like Selenium.

(Without this PR, clicking the force logout button returns 404, since it's a GET request and the server thinks that user is trying to access "forcelogout" repo under "settings" namespace)

Doesn't it need a CSRF token? If not then I think we should fix that while at it

Right now it doesn't since the endpoint is not using a WTForm. I'll add it.

rebased onto 2200ff4378efc8172850b2f07ec05f1984f049c1

Added a form to check for csrf and rebased.

LGTM and Jenkins is happy :) Thanks

Pull-Request has been merged by cverna
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.