#3593 Don't print lists of diff commits on info logging level, it unnecessarily pollutes server logs
Merged by cverna. Opened by bkabrda.
bkabrda/pagure diff-commits-debug  into  master

Download 3593.patch

Since upgrading to Pagure 4.91, my server logs are polluted with lists of diff commits that are pretty meaningless:

[Tue Aug 28 18:20:11.187824 2018] [:error] [pid 36] 2018-08-28 18:20:11,058 [INFO] pagure.lib.git: Diff commits: [<_pygit2.Commit object at 0x7f42f0c998f0>, <_pygit2.Commit object at 0x7f42f0c994d0>, <_pygit2.Commit object at 0x7f42f0c991b0>, <_pygit2.Commit object at 0x7f42f0c99bd0>, <_pygit2.Commit object at 0x7f42f0c99c90>, <_pygit2.Commit object at 0x7f42f0c99cb0>, <_pygit2.Commit object at 0x7f42f0c99910>, <_pygit2.Commit object at 0x7f42f0c995b0>, <_pygit2.Commit object at 0x7f42f0c99930>, <_pygit2.Commit object at 0x7f42f0c99e30>, <_pygit2.Commit object at 0x7f42f0c99d70>, <_pygit2.Commit object at 0x7f42f0c99830>, <_pygit2.Commit object at 0x7f42f0c99d10>, <_pygit2.Commit object at 0x7f42f0c99f10>, <_pygit2.Commit object at 0x7f42f0c998d0>, <_pygit2.Commit object at 0x7f42f0c99410>, <_pygit2.Commit object at 0x7f42f0c99450>, <_pygit2.Commit object at 0x7f42f0c992b0>, <_pygit2.Commit object at 0x7f42f0c999d0>, <_pygit2.Commit object at 0x7f42f0c99f50>, <_pygit2.Commit object at 0x7f42f0c994b0>, <_pygit2.Commit object at 0x7f42f0c99bf0>, <_pygit2.Commit object at 0x7f42f0c99810>, <_pygit2.Commit object at 0x7f42f0c996f0>, <_pygit2.Commit object at 0x7f42f0c99030>, <_pygit2.Commit object at 0x7f42f0c99db0>, <_pygit2.Commit object at 0x7f42f0c99f30>, <_pygit2.Commit object at 0x7f42f0c99dd0>, <_pygit2.Commit object at 0x7f42f0c99a50>, <_pygit2.Commit object at 0x7f42f0c99f90>, <_pygit2.Commit object at 0x7f42f0c99770>, <_pygit2.Commit object at 0x7f42f0c99890>, <_pygit2.Commit object at 0x7f42efbdd7f0>, <_pygit2.Commit object at 0x7f42efbdd990>, <_pygit2.Commit object at 0x7f42efbdda70>, <_pygit2.Commit object at 0x7f42efbdda90>, <_pygit2.Commit object at 0x7f42efbddb10>, <_pygit2.Commit object at 0x7f42efbddab0>, <_pygit2.Commit object at 0x7f42efbddbf0>, <_pygit2.Commit object at 0x7f42efbdd250>, <_pygit2.Commit object at 0x7f42efbddc90>, <_pygit2.Commit object at 0x7f42efbddcf0>, <_pygit2.Commit object at 0x7f42efbddcd0>, <_pygit2.Commit object at 0x7f42efbddcb0>, <_pygit2.Commit object at 0x7f42efbddd10>,

etc...
While I agree that these outputs might be useful when debugging, I think that they shouldn't be printed on info level.

:thumbsup:

Pull-Request has been merged by cverna

Metadata