@hellcp Can you please add a subpackage for this into the included spec file? It's in files/pagure.spec. You can model this after the other theme subpackages.

@ryanlerch Could you please review this? It's more in your wheelhouse. :smile:

It seems to work on my setup though, so barring any test failures, LGTM. :thumbsup:

:thumbsup:

Awesome! Thanks for the PR -- looks pretty awesome!

From the new master.html:

+     <nav class="navbar {{theme.masthead_nav_class}} {{theme.masthead_class}} navbar-expand">

I think we can now only have one variable here, maybe just theme.navbar_class or something like that. The only reason we split them up before was because of the strange way i implemented the navbars many moons ago :)

The change in master.html also makes the pagure.io and src.fp.o topbars render oddly. they need to have the ".masthead" class added to this theme variable.

Also, the new layout adds a little more padding to the topbar in the pagure.io and src.fp.o themes, so reducing the manual padding in the theme.css for those themes from 7px to 2px matches the way it currently looks.

Also, the new layout makes the padding of the topbar on the default theme a lot larger. While not exactly the same, adding a .p-0 to the new navbar class with the new theme variable suggested above looks pretty good IMHO.

Also, if we do introduce the new theme.navbar_class variable, the docs for theming will need to be updated as well.

Also, @pingou and I have chatted previously about maybe keeping the fedora themes in a sepearte repo, but happy to have the opensuse one in the main pagure repo until (if and when) we move the other themes elsewhere.

Also, is it okay with the OpenSUSE project for us to have a copy of the logo in our repo? Not sure about their logo guidelines for this, and just dont want to run into any troubles.

@ryanlerch The openSUSE Project has much more permissive rules for artwork than Fedora.

Before @hellcp proposed this PR, we talked to Richard Brown (openSUSE Chairman) to ensure we're okay, and we are, since we're not using the full openSUSE logo, only the Geeko icon. The wording for the logo is also such that it doesn't imply it's an official openSUSE instance or something like that.

As for the idea of separating the themes, there's a few changes that need to be made to how themes are stored on-disk for that to work out reasonably well. And for now, it actually helps in showing how Pagure can be themed.

I agree that there is just one variable needed there, as for p-0, again, that could interfere with the theming other themes might choose to do.

I will adjust {{theme.masthead_class}} to fit the new agenda and change the themes to actually use it, instead of using two classes (I just like the masthead, it sounds funky). If you point me at docs repo, I will update that too :D

As Neal already said, Geeko button falls out of the scope of trademark, so we don't have to worry about it.

@ngompa suggested on IRC that i manually merge this one, then i was just going to jump in and fix all the Fedora themes!

i acutally just merged your commits just before you commented, sorry!

Nah, I'm fine with that, less work for me :D

Cancelling this one, manually merged the commits.