pagure

#3632 move diff calc to workers
Merged by pingou. Opened by karsten.
karsten/pagure move_diff_calc_to_worker  into  master

Download 3632.patch

fixes #3599
calculating the differences between branches can take a long time if there are lots of branches. Move calculation to worker task and return immediately to unblock the server task. The PR dropdown menu will be filled in the background by the worker task.

Signed-off-by: Karsten Hopp karsten@redhat.com

This has merge conflicts, which caused the CI to fail. Could you please rebase it?

rebased onto 003479099139f16a67dcd8243fa6db9d6b633b2c

I need to update some tests, hold on...

rebased onto 7304a93bd75c04feacf4d3bbb7995d9749b31d7a

:thumbsup:

So IIUC this would block the http server thread for 100 seconds, right? I'd prefer if this endpoint returned a task id and then the client could poll /task/<taskid> endpoint to get result of that task once ready. WDYT?

@bkabrda do you need this in 5.0 or can it wait for 5.1?

I'd prefer to have it in 5.0, but not so much that I would suggest blocking the release on it.

This would be really good to have it in 5.0, because heavier PRs really suck. It's just not a good experience at all.

@ngompa but does this PR improve the UX in your testing?

rebased onto 40a893e9a59a3898678286ea67d6c1c9733a7402

1 new commit added

  • Make the internal endpoint return a task id and the client query this task

rebased onto b862c337fce002e851fdfe8c3437eb8787efaf50

rebased onto 7a04e093b405695756aeecc3166b592d2c1ea121

rebased onto 99f2990f15c3193afaaeb9ca0f8b1777deb933c6

Pretty please pagure-ci rebuild

rebased onto 96bea4633a0dea75ce9efa4102ecbc1f60a3317d

The code looks good to me. :thumbsup:

Thanks for the review :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.