pagure

#3637 Always import pagure.ui.issues, since repo settings need some endpoints from it
Merged by pingou. Opened by bkabrda.
bkabrda/pagure always-import-issues  into  master

Download 3637.patch

Not having this makes displaying settings of a repo fail with 500, since the ui_ns.update_tags is not available.
FWIW I'm not sure about a good way to test this, since the tests would need to reload whole Pagure with ENABLE_TICKETS = False and I'd probably have to figure out a whole new way of how to do this in the test suite (I can work on it if required, though).

What about moving out the update_tags endpoint instead?

I don't really have an opinion on this. I'm not very familiar with this part of Pagure. If you prefer moving the endpoint and tell me where to move it to, I'll be happy to do that instead.

This is what I had to do to get it working:

0001-Fix-accessing-the-settings-when-tickets-are-disabled.patch

What do you think?

@pingou LGTM, although I didn't test it in the environment where I hit this bug.

Cool, I'll apply it and close this PR. If it doesn't fix the issue, we'll revert the commit and go with your approach.

Thanks for the review!

Commit d364291f fixes this pull-request

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.