pagure

#3652 Add hooks to repoSpanner setups
Merged by pingou. Opened by puiterwijk.
puiterwijk/pagure repospannerhooks  into  master

Download 3652.patch

Signed-off-by: Patrick Uiterwijk patrick@puiterwijk.org

rebased onto 28e83d9378d3b3d4fd19ac0401f683ea802a8db9

missing _parser_ensure_project_hooks ?

Left over?

Yep, fixed.

Yep, removed.

Overall this looks fine to me, the only thing I'd ask is for more context in the commit message. What does this hook do? Are admins meant to install it via the cli? (Why upload rather than install?)... :)

@pingou well, the upload of the script to repoSpanner is a one-time thing, after which the admin is expected to configure the hook ID in the pagure config file.
After that, the hook will be automatically added to any new repositories.

So the upload steps would be in the install/upgrade guide, and that should be it.

ok, mind still putting some words about this in the commit message? (We can still copy/paste this for the doc afterward)

Done

rebased onto 63069fb37f7dd46034f378907ed232b137603567

rebased onto 554170b229796fbbd1fd60b4c37ffb82d0058c05

rebased onto 42c8139a76bd5bb0b0144f2ef312c4e23e4b28d7

rebased onto 6bc08ade9203d39f8bb91867709794821df74426

rebased onto 57fd220eb1ca1daa066d2f756fce182af2009289

rebased onto 600304c27fd0435d0a669b1965f913ab1ebe1f26

Pretty please pagure-ci rebuild

rebased onto df15830839612256823683cbb3b30be776d377e3

rebased onto 1c2eae5770a21b9d589f5c710cd1c606ee414756

rebased onto fa9ce24e54fb5822f9d1910ff25eb2e00b426a23

rebased onto c19862182aa1010c60faec39c9905b27a578bf07

rebased onto d2915898cd4eb050138ccde5a4086d8ae3e8d34c

Ok, Jenkins is not being cooperative... Let's just merge as they pass locally

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.