#3658 Port Vagrant setup to Fedora 28 and Python 3
Merged by pingou. Opened by akanksham.
akanksham/pagure py3-port  into  master

Download 3658.patch
no initial comment

:thumbsup:

I'm not sure about this change, is it really needed?

This should not be, since celery would be installed in the virtualenv, wouldn't it?

Or in this case since it's vagrant, in the VM itself

The celery binary is referenced in /usr/bin, but celery is only ever installed from the requirements to the environment. So, how does it end up in usr/bin?

It'll be /usr/bin/celery-3 for Python 3 on the system anyway.

I couldn't find celery-3 in usr/bin, probably because we didn't install python3-celery in the VM.

It is only installed from requirements.txt into the environment, so we can probably use that path instead.

I'm not sure how it ended up in usr/bin for the f25 python2 setup or in usr/local/bin this time

So we should set this to the celery binary in the virtualenv, right?

rebased onto b67311feb79a2637637b474d9d09a974fdf7d433

This looks good to me, let's rebase and get it in :)

@akanksham Are you able to rebase this so @pingou can merge this?

rebased onto e87817c3b1b67dd072675bc5a6512c8534aede67

@akanksham do you think you could rebase one more time, it has one small conflict, nothing major.

This way you and @alexgleason may be able to test it one more time before we get it in :)

rebased onto 2e72a9a54bdf4f83ad908ded836cf56cf8575477

Sure, it seems to be working fine.

rebased onto 4d6eb3edafa0bc5d887e6a599b1a831bc7ffbbe1

Pull-Request has been merged by pingou

Metadata