How does this make the fedmsg notifications better?
Commits pushed to a new branch will be notified (and just vs the default branch, not from the start of the repo), new commits are published when there is a force-push
OK, :+1:
Hm, with the latest change here, what if someone force pushes on a branch that is not a descendant of the default branch?
It will always be a descendant of the default branch, but it might go way way back and then we will end up sending a lot of notifications (similar to what we do now if you rebase a feature branch on the top of master/develop after having merged things in master/develop)
Say there are 100 commits on develop, the default branch. All pushed and pagure knows about them. The default branch points at that 100th commit.
What happens if I:
rewrite-from-scratch
My only point is that you can create branches that are not descendants of the default branch. If you're sure it won't cause hiccups, that works for me. :)
:+1: still here.
Well, there is a common commit, the original one ;-)
So in theory (read: afaik/as much as I understand it) it should announce only the new commits (the one or two mentioned in point 2)
Thanks for the review :)