pagure

#3820 Make the mirroring feature work with older git
Merged by pingou. Opened by pingou.
fix_mirroring  into  master

Download 3820.patch

The GIT_SSH_COMMAND environment variable was added in 2.10 but we
want pagure to work with older git version, so we are switching
to GIT_SSH with a helper script generated on the fly.

In addition, this commit adds the logic to pull all the branches stored
in pagure so when we push --mirror they are all synced.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto fa60d93a8c66da323f2bc2e8414dcc5541861704

Any reason why you don't just ship this script with Pagure, and reuse the same copy everywhere?
The whole reason of the variable $SSHKEY in it was so that's possible :).

Considering its length I thought it was as easy to just write it down when needed :)

rebased onto 8decc7cd47394894f8b03d8211735955178863ce

Looks ok to me :thumbsup:

There were a couple of test failures:

15:26:36 Failed tests:
15:26:36 FAILED test: py-test_pagure_lib_task_mirror
15:26:36 FAILED test: py-test_style

Could you please look to resolve those?

15:26:36 FAILED test: py-test_pagure_lib_task_mirror

This one turned out to have caught two legit typos :)

rebased onto bab01f9b7cf081bb89402403bac93012eca86d4d

rebased onto bab01f9b7cf081bb89402403bac93012eca86d4d

1 new commit added

  • Drop un-used imports

rebased onto 4a7ea5ccf1c65074826c28be1c42f4e2b8e648b5

rebased onto 605eaaa8ad75b1733e4a56ad1f0506b9055e5f80

:thumbsup:

Thanks for the reviews!! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.