pagure

#3832 When a pushed in made to a branch in a PR, update the PR
Merged by pingou. Opened by pingou.
update_pr_on_push  into  master

Download 3832.patch

Fixes https://pagure.io/pagure/issue/3684

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

 
15:35:22 Failed tests:
15:35:22 FAILED test: py-test_style

This should pass after the code is blackened, I think.

rebased onto 96f75d22a8fc05b170fab8af3fea58bf2e153495

I also want to put in some kind of tests before merging this PR :)

rebased onto b815e32322530f101ed4f18f97c9e77d73c88878

1 new commit added

  • Add tests for pagure.lib.tasks.update_pull_request

rebased onto 736f3061ad5dfea992934f241a19b8430cc84728

Maybe just six.u() on both? Should be automatic no-op on py3, and do the same on py2 as you're doing, I think?

One small idea, otherwise +1.

Worth a try :)

We actually want the opposite, bytes not unicode :(

And six.b() doesn't seem to do what we want :(

Going to leave as it

Thanks for the review! :)

rebased onto 9742019b58e32ad9f61be92f4de72f84a9d75ea1

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.