pagure

#3904 Update git-multimail so it works with py2 and py3
Merged by pingou. Opened by pingou.
update_multimail  into  master

Download 3904.patch
no initial comment

1 new commit added

  • Flake8 fixes for pagure's style for git-multimail

1 new commit added

  • Flake8 fixes for pagure's style for git-multimail

5 new commits added

  • Flake8 fixes for pagure's style for git-multimail
  • Indicate where our git-multimail is coming from
  • Run black over the entire project
  • Run black over upstream's git-multimail
  • Update git-multimail to the 1.4.0 version

5 new commits added

  • Flake8 fixes for pagure's style for git-multimail
  • Indicate where our git-multimail is coming from
  • Run black over the entire project
  • Run black over upstream's git-multimail
  • Update git-multimail to the 1.4.0 version

I think we should not make any changes to the git-multimail.py file, other than renaming it.
We should exclude it from the style checks, and probably add the source information in a file to the side or in the documentation.

All of those changes make it harder to determine which version it is, that nothing is changed from upstream, and they will have to be repeated every time we rebase.

I think we should not make any changes to the git-multimail.py file, other than renaming it.
We should exclude it from the style checks, and probably add the source information in a file to the side or in the documentation.

I've been looking on how to exclude it from black, but that doesn't seem trivial unfortunately :(

All of those changes make it harder to determine which version it is, that nothing is changed from upstream, and they will have to be repeated every time we rebase.

Indeed that'll be annoying

I think we should not make any changes to the git-multimail.py file, other than renaming it.
We should exclude it from the style checks, and probably add the source information in a file to the side or in the documentation.

I've been looking on how to exclude it from black, but that doesn't seem trivial unfortunately :(

  --exclude TEXT                  A regular expression that matches files and
                                  directories that should be excluded on
                                  recursive searches.  An empty value means no
                                  paths are excluded. Use forward slashes for
                                  directories on all platforms (Windows, too).
                                  Exclusions are calculated first, inclusions
                                  later.  [default: /(\.git|\.hg|\.mypy_cache|
                                  \.tox|\.venv|_build|buck-out|build|dist)/]

5 new commits added

  • Run black over the entire project
  • Start a documentation file for black using a pyproject.toml file
  • Make black ignore git-multimail
  • Indicate where our git-multimail is coming from
  • Update git-multimail to the 1.4.0 version

5 new commits added

  • Run black over the entire project
  • Start a documentation file for black using a pyproject.toml file
  • Make black ignore git-multimail
  • Indicate where our git-multimail is coming from
  • Update git-multimail to the 1.4.0 version

1 new commit added

  • Let's see if pyproject will work in jenkins

1 new commit added

  • Let's see if pyproject will work in jenkins

1 new commit added

  • Fix letting flake8 ignore git-multimail

1 new commit added

  • Fix letting flake8 ignore git-multimail

6 new commits added

  • Fix letting flake8 ignore git-multimail
  • Let's see if pyproject will work in jenkins
  • Run black over the entire project
  • Start a documentation file for black using a pyproject.toml file
  • Indicate where our git-multimail is coming from
  • Update git-multimail to the 1.4.0 version

:thumbsup:

Thanks :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.