#408 Record in the database the last time a PR was updated
Merged by pingou. Opened by pingou.
updated_on  into  master

Download 408.patch
no initial comment

Maybe use the MAX of date_created and date_closed or something?

Shouldn't this be without parenthesis? Otherwise I think it only evaluates this during the definition.

Which MAX? There is one value per row

And there is no date_closed :)

That's if you use datetime, not func: http://docs.sqlalchemy.org/en/rel_0_9/core/defaults.html

I see, another field to add? :)

Sorry, replied on the wrong place :)

I see, another field to add? :)

That's the idea of the update_on field, how will the PR be updated once it's closed? :)

I think you can add comments post-close, not?

That won't change the PR record, just add a new entry in the pr_comment table :)

You can't change the title after closing it?

(and you are sure there will never be any other fields you can change after closing the ticket?)

If we want, I'd rather make the updated_on field be a closed_on field since that's the info I care for anyway

Note: currently you can't change the title at all and it would be an easyfix to ensure we can't update the title of a closed PR

Title was just an example. Maybe we will have fields that you can change after the PR is closed was the general idea.

+1 on this. You might want to consider adding a closed_at sometime maybe :)

Metadata