PR#4160: [dev-data] fix create_session and create_engine -

pagure

#4160 [dev-data] fix create_session and create_engine

Closed Jan 3, 2019 by pingou. Opened Dec 31, 2018 by rom1dep.

rom1dep/pagure dev-data into master

no initial comment

ngompa commented Dec 31, 2018

:thumbsup:

pingou commented Jan 3, 2019

We're importing from pagure.lib.query import create_session and calling create_engine ?

I'm also not sure what this fixes, if we were calling the wrong method, it looks like we still are and otherwise, I'm not quite sure I see what we're fixing. I'm pretty sure the old syntax is valid.

pingou commented Jan 3, 2019

Ok, reading https://pagure.io/pagure/pull-request/4152 I see where I was wrong.

I'm going to merge #4152 as it was opened first and I prefer its logic.

Thanks for your PR though and thanks for taking the time to look into this :)

Pull-Request has been closed by pingou

Jan 3, 2019

Metadata

Assignee

None

Tags

No Tags

pagure

#4160 [dev-data] fix create_session and create_engine Closed Jan 3, 2019 by pingou. Opened Dec 31, 2018 by rom1dep. rom1dep/pagure dev-data into master

Metadata

#4160 [dev-data] fix create_session and create_engine

Closed Jan 3, 2019 by pingou. Opened Dec 31, 2018 by rom1dep.

rom1dep/pagure dev-data into master