pagure

#4165 Fix PR filtering by status in API calls
Merged by pingou. Opened by lenkaseg.
Unknown source master

Download 4165.patch

1st commit: PRs and assignees os PRs added in dev-data.py
2nd commit: fix the PR filtering by status in API calls and add tests.

Here are my results with testing the change:
https://pastebin.com/1nNDy2hi

rebased onto 0c78f4767a0ce072cf0887564f9613fe68108706

:thumbsup:

I think this test would fit better in test_pagure_flask_api_fork.py
Basically the filenames of the test file somewhat reflects the file that is being tested, in this case pagure/api/fork :)

Ok, makes sense :)

2 new commits added

  • fix PR filtering by status in API calls
  • add PRs and assignee data to dev-data.py

I tested it and even after moving the test to test_pagure_flask_api_fork.py the results are the same like in the pastebin above. I hope I didn't make any mistake :)

Still looks good. :smile:

This can be dropped (as in un-done) :)
Edited by pingou

I'd add these changes: https://paste.fedoraproject.org/paste/glWNGOuBSeiqzEBDOv8kRg (and rebase)

:)
Edited by pingou

Ok! That's a good idea to add also the status="merged" test.

Pingou, since you're adding this line:

self.assertEqual(data['total_requests'], 3),

should I remove the line 224:

self.assertEqual(len(data['requests']), 3)

?

You can if you want, I'm more of a "belt and suspender" guy when it comes to tests :)

So then I leave it :)

2 new commits added

  • fix PR filtering by status in API calls
  • add PRs and assignee data to dev-data.py

rebased onto 4baced9e59f01392b4cee40277056c212f063b06

rebased onto 70e0b054b0b44274c36edcc855c74e03f32a5cbb

Commit 96f2fece fixes this pull-request

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.