Looking at the man page for this it seems that it won't be pushing all the tags, only the ones that are reachable from the refs being pushed.

So if you have tags that are in another branch, they may not get pushed.

This makes me wonder if merging this won't be a source of confusion sometime where some tags are pushed but not all of them :(

What do you think?

My POV is that this is exactly what we want - push all tags that are reachable from the pushed branch.

When this is used for forking, all tags reachable from all branches will be pushed. When this is used for merging PRs, only the tags reachable from the branch that is being merged will be pushed. I'd call this an expected behaviour. Do you see other specific cases where this is used that would be confusing?

When this is used for forking, all tags reachable from all branches will be pushed.

This is the part I wasn't sure basically.

Should we add a test for this?

Yeah, I'll add some tests later this week.

:thumbsup:

Thanks! :)