From 78ff546fa4dc2744e45eb91bf5b353a6a446b10d Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Feb 13 2019 20:53:21 +0000 Subject: [PATCH 1/2] Leave the application's log handler alone Not having handlers used to be necessary when we were sending error emails by default but this is no longer the case and this debugging information is sometime most useful when trying to debug tests. Signed-off-by: Pierre-Yves Chibon --- diff --git a/tests/__init__.py b/tests/__init__.py index 6a61cf2..565790c 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -403,8 +403,6 @@ class SimplePagureTest(unittest.TestCase): imp.reload(pagure.lib.tasks_services) self._app = pagure.flask_app.create_app({'DB_URL': self.dbpath}) - # Remove the log handlers for the tests - self._app.logger.handlers = [] self.app = self._app.test_client() self.gr_patcher = mock.patch('pagure.lib.tasks.get_result') From 415baf1468a8d9618d965f4b95f16118827efec1 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Feb 13 2019 21:09:29 +0000 Subject: [PATCH 2/2] Fix typo in the fedora-pip-py3 container and make the script executable Signed-off-by: Pierre-Yves Chibon --- diff --git a/dev/containers/fedora-pip-py3 b/dev/containers/fedora-pip-py3 index 7d7b31a..6f4c1b7 100644 --- a/dev/containers/fedora-pip-py3 +++ b/dev/containers/fedora-pip-py3 @@ -5,7 +5,7 @@ RUN dnf -y install \ redhat-rpm-config \ python3-devel \ libgit2-devel \ - python3-tox + python3-tox \ libffi-devel \ m2crypto \ zeromq-devel \ @@ -15,7 +15,8 @@ RUN dnf -y install \ git RUN cd / \ - && git clone https://pagure.io/pagure.git + && git clone https://pagure.io/pagure.git \ + && chmod +x /pagure/dev/containers/tox_py3.sh # Install pygit2 manually, outside of the virtualenv since it is tightly coupled # which the version of libgit2 installed on the system.