pagure

#4354 Remove extra "s" character from the starred repos page
Merged by pingou. Opened by wattersmt.
Unknown source master

Download 4354.patch

There was an extra "s" in the template which would cause pagure to display a header such as "6 Projectss".

:thumbsup:

Thanks :)

rebased onto ca31b81ad54db128c88c71bf09c31b3b89614c9d

pretty please pagure-ci rebuild

Un-tested but I'd not be surprised if the fix was along the lines of: 

--- a/ tests/test_pagure_flask_ui_star_project.py       
+++ b/ tests/test_pagure_flask_ui_star_project.py       
@@ -194,7 +194,7 @@ class TestStarProjectUI(tests.SimplePagureTest):
         )
         self.assertIn(
             '<span class="btn btn-outline-secondary disabled opacity-100 '
-            'border-0 ml-auto font-weight-bold">0 Projects</span>',
+            'border-0 ml-auto font-weight-bold">0 Project</span>',
             output_text)
         # make pingou star the project
@@ -224,7 +224,7 @@ class TestStarProjectUI(tests.SimplePagureTest):
         )
         self.assertIn(
             '<span class="btn btn-outline-secondary disabled opacity-100 '
-            'border-0 ml-auto font-weight-bold">1 Projects</span>',
+            'border-0 ml-auto font-weight-bold">1 Project</span>',
             output_text)
         self.assertEqual(
             output_text.count('class="list-group-item"'), 1)
@@ -264,7 +264,7 @@ class TestStarProjectUI(tests.SimplePagureTest):
         )
         self.assertIn(
             '<span class="btn btn-outline-secondary disabled opacity-100 '
-            'border-0 ml-auto font-weight-bold">0 Projects</span>',
+            'border-0 ml-auto font-weight-bold">0 Project</span>',
             output_text)
         self.assertEqual(
             output_text.count('class="list-group-item"'), 0)

Commit 4f046dff fixes this pull-request

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.