#4380 Replace calls to pygit2.clone_repository by calls to git clone directly
Merged by pingou. Opened by pingou.
no_more_pygit2_clone  into  master

Download 4380.patch

pygit2.clone_repository() is leaking file descriptors on large git repo
making pagure generate "Too many open files" errors while it runs.
This leads to certain task no longer working, especially the tasks
around the tickets or PRs repositories of large project, lowering
significantly their interest.
With this commit we're now shelling out to git directly the cloning
action, this should fix the leak of file descriptors and thus allow
pagure to go back to its expected behaviour.

Fixes https://pagure.io/pagure/issue/4277

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

:thumbsup:

rebased onto a87742c3921b3e6d2a41151ca68e665d694495e3

Build passed.

Thanks for the review :)

Pull-Request has been merged by pingou

Metadata