PR#4388: Fix the toggle button -

pagure

#4388 Fix the toggle button

Merged Mar 29, 2019 by pingou. Opened Mar 28, 2019 by pingou.

fix_toggle into master

pingou commented Mar 28, 2019

We had two issues, the JS function toggle() was in if/else statements
which means it wasn't always included and thus not always working.
The second issue was a missing '.', the line:
checkboxes[i].checked = !checkboxes[i]checked;
was meant to be:
checkboxes[i].checked = !checkboxes[i].checked;

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

pretty please pagure-ci rebuild

Mar 28, 2019

lenkaseg commented Mar 28, 2019

Also, there is missing one semicolon:
span class="btn" onclick="toggle()" should be
span class="btn" onclick="toggle();"
But it is only a detail.

Edited Mar 28, 2019 by lenkaseg

pingou commented Mar 28, 2019

They aren't needed :)

lenkaseg commented Mar 28, 2019

I know, I was just wondering if it doesn't look more "old school"...now I read it's pretty hot topic :)

pingou commented Mar 28, 2019

Would you have a link to share? :)

lenkaseg commented Mar 28, 2019

Oh, nothing in particular, just fast googling :) I was just surprised by the amount of blog posts and heated discussions about such a minor thing :) You're right, better without semicolons.

pingou commented Mar 29, 2019

@lenkaseg does that mean you're :thumbsup: on this PR?

lenkaseg commented Mar 29, 2019

:thumbsup:

pingou commented Mar 29, 2019

Thanks! :)

Pull-Request has been merged by pingou

Mar 29, 2019