#4421 Anitya integration in the srcfpo theme and related fixes
Merged by pingou. Opened by pingou.
anitya_integration  into  master

Download 4421.patch

This PR contains a number of commits to make easier the integration with anitya
in the srcfpo theme.

It relies on: https://pagure.io/pagure-dist-git/pull-request/70

Demo can be seen at: http://ambre.pingoured.fr/public/Screencast_pagure_distgit_anitya.webm

Shouldn't this be a drop down in the main overview area, rather than an awkward drop-down in the sidebar?

I kinda liked it there, but we can always move it if desired.

The thing for me is that there are already two lines of buttons and this one would then be in a third line (it's not an action related to pagure itself and it's not a link to other resources about this package), I'm not sure that'll look so nice :(

@pingou My thing is that the button style looks really awkward in the sidebar. If it could look more like the other sidebar things, I'd be fine with it...

5 new commits added

  • Make the main_app variable accessible to all templates
  • Add a customized repo_master_sidebar for the srcfpo theme
  • Only show settings for blueprints having a settings endpoint
  • Move the side-bar of the repo_master into its own template
  • Make the side-bar a 2 units column

The other sidebar buttons are "tab switch" and basic button while this is a drop-down, we don't any of these in the side bar and we can't quite make it looks like the other as it behaves entirely differently

1 new commit added

  • Fix tests for the change in indentation in the html

:thumbsup:

rebased onto cbc3fbe18fb12751ff8dcf1bd692167348e71634

rebased onto 4e5dede6421eb0ade1d883245c7454f5cf461e14

Tests passed but they failed to sync the artifacts out :(

But they passed, let's get this in :)

Pull-Request has been merged by pingou

Metadata