Our OSCI Pagure instance was returning 500 when there was a pull request which was adding a new git submodule into the repository. This patch fixed the problem.

Note I'd love to add some tests, but I am gonna need some guidance on where exactly those tests should go.

Thanks!

07:24:57  Failed tests:
07:24:57  FAILED test: py3-test_style

@msrb Could you please run black on your code to fix the style?

@ngompa absolutely! Thanks.

So the problem was:

$ python -m flake8 --ignore=E712,W503,E203 pagure/
pagure/lib/git.py:2747:80: E501 line too long (108 > 79 characters)

It should be fixed now. I force-pushed the fix, hope it's ok.

That's fine, we'll see if the tests agree. :wink:

They don't :) Let me try to figure out what is going on there...

Now the problem is not on your side, we have a broken pipeline due to some f30/pip updates

@msrb can you rebase the pr? the test problem should be fixed now

@jlanda rebased :wink: let's see now...

We are green, folks! \o/

:thumbsup:

For the tests, I'd say feel free to add them to a new file :)

@msrb Do you need some help to get started on the tests?

Sorry for the delays guys - I will try to finalize this PR by the end of this week.

@msrb Any effort going into this now?

I wanna land this on next release. Can I finish the tests @msrb ?

I'll took this silence as a yes :)

@jlanda Any chance you're planning on taking a crack at this soon?

@ngompa is that something we want to have in the next release? If so I can create a new PR from the patch and write the missing tests.

@wombelix Yes, this is something we want to have. Being able to properly recognize submodules would be very useful.

This project has moved to https://forge.fedoraproject.org/apps/pagure. As part of the migration, all open pull requests on pagure.io have been closed. If you'd like to continue working on this, please fork the repository on the new forge and re-submit your PR there.