#459 Fixing clear button functionality in pull request page
Merged by farhaan. Opened by farhaan.
farhaan/pagure pr-clear-button  into  master

Download 459.patch
no initial comment

I fail to understand why we make clear_comment a button and then have javascript to clear the field, when there's the perfectly valid native HTML <input type="reset" ?

Actually, I think this might have been so that we can actually reset the text to the replied-to comment in case you hit Reply once. At least, that's what I would like to see happened, but I guess @pingou will have to tell what his intention was.

Code looks good but I'm not sure to understand what @puiterwijk was saying just above.

The idea is indeed, to be able to clear the comment box from all content, either something you typed, or something that was placed there after hitting the reply button.

Does that make sense?

@puiterwijk with this explanation, does the code make sense for you?

Okay, my logic was not taking into account the way the Reply button works.
After reading that, this PR looks correct to me.

Let's merge then, thanks @puiterwijk for the review and @farhaan for the PR :)

Commit 5c0a46cb fixes this pull-request

Pull-Request has been merged by farhaan.bukhsh@gmail.com

Metadata