The git.tag.creation event does not propagate the newrev making it difficult to be interpreted by other tools like Zuul. This patch adds the rev info to that notification payload but also to branch events.
The test suite is failing due to #4611 . #4612 should temporary fix it.
rebased onto ff73e84aad01a7abdea03ca52a3c7bf996d60962
Should we add some tests to this?
rebased onto e6748195062ee4f1876aeb13363ef77517c382dd
Hi, I'll be happy to add tests. Could you give me some guidance where and how to add notifications tests ?
Thanks a lot !
rebased onto 92c0a5334f5bfc7ab38315fbbf5e4a78730ccefc
rebased onto 3e6add191816df3d42b92a58250fd9221c387995
Cool, thanks! :)
Let's wait for jenkins and get this in :)
rebased onto 5fe4ac73396674a6516554bf65a6ed2ed2d686d3
pretty please pagure-ci rebuild
Try with python3 -m black -l79 tests/test_pagure_send_notification.py
python3 -m black -l79 tests/test_pagure_send_notification.py
1 new commit added
black fix
Thanks @jlanda
rebased onto 9e5f51c951c6cab20fe81419320ed740533e2f2f
Pull-Request has been merged by pingou
The git.tag.creation event does not propagate the newrev
making it difficult to be interpreted by other tools like
Zuul. This patch adds the rev info to that notification payload
but also to branch events.