pagure

#4616 Allow changing allow_rebase from pull-request edit
Merged by pingou. Opened by jlanda.
jlanda/pagure rfe-edit-pr-allow-rebase  into  master

Download 4616.patch

This implements the ability to edit allow_rebase property when editing pull requests.

Fixes #4600 .

Note:

allow_rebase seems as a property just for the PR creator, but every commiter is allowed to edit pull_requests . Should we block allow_rebase editing to just pr author?

Should we block allow_rebase editing to just pr author?

:thumbsup:

rebased onto 6bf545ff02c63b1cd929ae860c2d626fa8934b08

rebased onto 750d3c799c9260564a213659c009fa9892297f40

allow_rebase edition blocked to the request author.

I'll work on tests later today

rebased onto 45774e633b6f7cab491808e87cada6ba2f3a69dc

rebased onto 0f04dcccfe131a8d677f41c96d694989a904c08a

4 new commits added

  • Add unit test for flask.ui.pull_request_edit
  • tests: move pull request creation function from pr_no_sources test suite to __init__
  • Edit pull request form: don't print None as initial comment when initial_comment == None
  • Allow changing allow_rebase from pull-request edit

4 new commits added

  • Add unit test for flask.ui.pull_request_edit
  • tests: move pull request creation function from pr_no_sources test suite to __init__
  • Edit pull request form: don't print None as initial comment when initial_comment == None
  • Allow changing allow_rebase from pull-request edit

4 new commits added

  • Add unit test for flask.ui.pull_request_edit
  • tests: move pull request creation function from pr_no_sources test suite to __init__
  • Edit pull request form: don't print None as initial comment when initial_comment == None
  • Allow changing allow_rebase from pull-request edit

4 new commits added

  • Add unit test for flask.ui.pull_request_edit
  • tests: move pull request creation function from pr_no_sources test suite to __init__
  • Edit pull request form: don't print None as initial comment when initial_comment == None
  • Allow changing allow_rebase from pull-request edit

4 new commits added

  • Add unit test for flask.ui.pull_request_edit
  • tests: move pull request creation function from pr_no_sources test suite to __init__
  • Edit pull request form: don't print None as initial comment when initial_comment == None
  • Allow changing allow_rebase from pull-request edit

Updated with tests.

BTW, I found that empty initial_comments where printed as None on html textarea, so I changed that too.

Hm, this is odd the tests are passing but I'd expect some of the tests here to not pass the black check.

Could you run black on the new tests?

:thumbsup:

Hm, this is odd the tests are passing but I'd expect some of the tests here to not pass the black check.
Could you run black on the new tests?

black is happy :smile: 

[julen@julenlanda pagure]$ git log --pretty=format:'%h' -n 1
0125868e
[julen@julenlanda pagure]$ python3 -m black -l 79 tests/test_pagure_flask_ui_pr_edit.py
All done! ✨ 🍰 ✨
1 file left unchanged.

Those are the lines I'd expect black to cut into two but ok :)

4 new commits added

  • Add unit test for flask.ui.pull_request_edit
  • tests: move pull request creation function from pr_no_sources test suite to __init__
  • Edit pull request form: don't print None as initial comment when initial_comment == None
  • Allow changing allow_rebase from pull-request edit

black continues happy

rebased onto cd52b806ce673db066300c0c38097a9549f9e425

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.