pagure

#4622 PR list Flags: fix formatting
Merged by pingou. Opened by ferdnyc.
ferdnyc/pagure pr-flags-formatting  into  master

Download 4622.patch

The template for the PR list had a paragraph close-tag mistakenly placed inside of a for loop instead of outside, which caused the PR's Flags list to be generated with source like:

<div class="d-flex prs_flag_list">
                      <p>Flags:
                        <span class="badge badge-danger font-size-09" title="jenkins #2295">
                            1 failure
                        </span>
                      </p>
                        <span class="badge badge-info font-size-09" title="jenkins #2305">
                            1 pending
                        </span>
                      <p></p>
                        <span class="badge badge-success font-size-09" title="jenkins #2296">
                            1 success
                        </span>
                      <p></p>
                  </div>

Fixes #4623

And I'm just now realizing you can attach images to issue discussions, but not PR discussions. So I've subsequently opened issue #4623 where you can see a screenshot of the problem.

:thumbsup:
Edited by jlanda

Nice catch, thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.