#4728 Fix the regenerate-repo actions
Merged by pingou. Opened by pingou.
fix_regenerate_repo  into  master

Download 4728.patch

This action allows to re-generate the JSON representation of each issue
or PR in a repo in their corresponding git repo.
The call they made to pagure.lib.git.update_git contained an argument
"repofolder" that has been removed a while back and it looks like these
lines were not updated for this.

This commit fixes that

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

I'll see if I can come up with some tests for this, but if someone else wants to look at the tests before I get to them, feel free :)

rebased onto e58b14426e198d098e9a9bc85bc24e8a5e6c11b5

rebased onto 4dd0ab874dd8420bf52287c7c2a6bea51f03942d

rebased onto 832075c693f7b944174941a4ec3d2c4129cbdc7d

rebased onto a1f2b7d80f1bd5b996a6f5191f5e2a96578c8a5a

09:16:15  Failed tests:
09:16:15  FAILED test: py3-test_style

setUp() calls FakeUser without argumentos while tests are calling it with explicit username="pingou" I believe that pingou is the default value for username, but would not be easier to read if all the calls were homogeneus?

I start to hate the different black glitch between f31 and f29. Apart from the little comment and the styling thing, wfm

rebased onto ba8fef40553334d3c2d2da3edcd9d2f9a66d504d

rebased onto 5cd16cf768873020a0461e256e3cdf4d6ec2ca2d

setUp() calls FakeUser without argumentos while tests are calling it with explicit username="pingou" I believe that pingou is the default value for username, but would not be easier to read if all the calls were homogeneus?

The default username of FakseUser is actually username not pingou :)

setUp() calls FakeUser without argumentos while tests are calling it with explicit username="pingou" I believe that pingou is the default value for username, but would not be easier to read if all the calls were homogeneus?

The default username of FakseUser is actually username not pingou :)

Ar, I missed :D

:thumbsup:

:thumbsup:

rebased onto 6d1c878c3ea5beb71082cbb352108b3afd7c3584

Pull-Request has been merged by pingou

Metadata