Tested to work as expected in a local Vagrant instance with THEME set to srcfpo.
THEME
srcfpo
Thanks to @jlanda for the pointers.
@decathorpe Could you amend your commit to add your sign-off? git commit --amend -s should be sufficient.
git commit --amend -s
:thumbsup:
Thanks Fabio :)
src.fp.o's theme is not tested. The jenkins failure is unrelated to this PR
Yeah, I tried running the test suite, but it took ages and the failures looked unrelated to my change, so I gave up ...
Could you amend your commit to add your sign-off? git commit --amend -s should be sufficient.
Done. After 10 years of contributing to FOSS projects, I still don't know what it's for, but well ... it's there now.
rebased onto 4f2b11f399a6ed5e74eb5ba13ebb2009172108fd
Since this isn't covered in the tests, I'm going to merge it despite the current test results which I hope fill be fixed by #4739
Thanks for the patch!
Pull-Request has been merged by pingou
Thanks for merging it so quickly :) Maybe I can manage to make a few more contributions going forward.
You're more than welcome, thank you for fixing this!
Tested to work as expected in a local Vagrant instance with
THEMEset tosrcfpo.