pagure

#4743 lib/query: order pull requests based on updated_on column when we want to order based on last updated time
Merged by pingou. Opened by jlanda.
jlanda/pagure fix-pr-order  into  master

Download 4743.patch

Based on https://pagure.io/pagure/issue/4464#comment-624915 , modify the ordering key when we search pull requests with last_updated ordering_key

I choose to keep last_updated as key to keep backward compatibility

The previous PR included updating the timestamp when a pr was flagged.

I would like to add it here too, but don't know wich of them should I update

rebased onto 6f0ec0592e2189e37aca21575bf6834e1113f47e

:thumbsup:

I would like to add it here too, but don't know wich of them should I update

The way I see it, we likely never want to touch last_updated for PRs (and I just realized that for issue last_updated is basically the equivalent of updated_on for PRs, damn this is not going to help to make things clear in the future :s).

I would like to add it here too, but don't know wich of them should I update

The way I see it, we likely never want to touch last_updated for PRs (and I just realized that for issue last_updated is basically the equivalent of updated_on for PRs, damn this is not going to help to make things clear in the future :s).

And the last_updated api key for order internally is updated_on, Which is nice for external pow since both issues and PRs share key name, but internally is going to confuse even more
Edited by jlanda

1 new commit added

  • update updated_on on add_pull_request_flag

1 new commit added

  • templates/issues.html: render updated_on instead of last_updated on related pull request's info

Let's get this in, thanks!

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.