From 715a70b843cfe74ecb342376d679a5c68640c8f3 Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Mar 06 2020 08:44:15 +0000
Subject: [PATCH 1/2] Make the reset button not the default action of the form


Basically, if you enter a value in the form and press the "enter" key,
the first/default submit button of the form is triggered. This meant in
this case that the "reset" action was the one triggered by default.

With this change, we make the reset button be of type "button" instead
of being of type "submit", thus making it not the default action while
still looking pretty.

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

---

diff --git a/pagure/themes/srcfpo/templates/repo_master_sidebar.html b/pagure/themes/srcfpo/templates/repo_master_sidebar.html
index 9a94910..62615cc 100644
--- a/pagure/themes/srcfpo/templates/repo_master_sidebar.html
+++ b/pagure/themes/srcfpo/templates/repo_master_sidebar.html
@@ -205,7 +205,7 @@
             </p>
           </div>
           <div class="modal-footer">
-            <button class="btn btn-secondary" type="submit" title="Update bugzilla overrides" id="reset_assignees">
+            <button class="btn btn-secondary" type="button" title="Update bugzilla overrides" id="reset_assignees">
                Reset to defaults
             </button>
             <button class="btn btn-primary" type="submit" title="Update bugzilla overrides" id="update_assignees">

From 4300d72364eacf8fe9d7e734e4318ae123e3c87f Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Mar 06 2020 08:47:19 +0000
Subject: [PATCH 2/2] Move the logging to the end of the action rather than the start of it.


Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

---

diff --git a/pagure/themes/srcfpo/templates/repo_master_sidebar.html b/pagure/themes/srcfpo/templates/repo_master_sidebar.html
index 62615cc..61e7d04 100644
--- a/pagure/themes/srcfpo/templates/repo_master_sidebar.html
+++ b/pagure/themes/srcfpo/templates/repo_master_sidebar.html
@@ -295,7 +295,6 @@
              'fedora_assignee': $('#fedora_assignee').val()
           },
           success: function(res) {
-            console.log("Successfully changed the bugzilla assignees");
             $("#fedora_assignee_txt").text(res.fedora_assignee);
             $("#epel_assignee_txt").text(res.epel_assignee);
             $('#modal_assignee').modal('hide');
@@ -303,6 +302,7 @@
             $('#update_assignees').attr('disabled', false);
             $('#update_assignees').text('Update');
             $('html').css('cursor', 'default');
+            console.log("Successfully changed the bugzilla assignees");
             return false;
           },
           error: function(res) {