pagure

#4769 Handle attempts to create an existing git tag
Merged by pingou. Opened by pingou.
two_git_tags  into  master

Download 4769.patch

If someone attempts to create a git tag that already exists, pygit2
will raise an error that we are now catching.
To distinguish if the git tag that was asked to be created was created
or not, we also include in the JSON returned a tag_created
field that is a boolean indicating if the tag was created or not
(not created in this case means that it already existed).

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto 36b3b1cdc897ac4bf0c5840c133d4e0118965028

rebased onto b6b25cfd199a3cdd44607063c8cf9e73179fb833

@pingou what if we wanted to update the git tag via API? That is, move it from one commit to another?

1 new commit added

  • Attempt to get this working with older pygit2

@pingou what if we wanted to update the git tag via API? That is, move it from one commit to another?

That is a very good question, to which I do not have the answer atm :)

1 new commit added

  • Attempt to make the tests pass with markdown 3.2.1

pretty please pagure-ci rebuild

2 new commits added

  • Allow blocking updating git tags via the API
  • Allow to force the creation of a git tag

This description doesn't make sense. Perhaps this instead:

This configuration key determines whether users are allowed to update existing git tags via the API. When set to ``False``, this essentially makes the API ignore whether the ``force`` argument is set or not.
Edited by ngompa

5 new commits added

  • Allow blocking updating git tags via the API
  • Allow to force the creation of a git tag
  • Attempt to make the tests pass with markdown 3.2.1
  • Attempt to get this working with older pygit2
  • Handle attempts to create an existing git tag

rebased onto cd1dc901e6cf9a780ae5b5645c8e543b45f98a74

5 new commits added

  • Allow blocking updating git tags via the API
  • Allow to force the creation of a git tag
  • Attempt to make the tests pass with markdown 3.2.1
  • Attempt to get this working with older pygit2
  • Handle attempts to create an existing git tag

5 new commits added

  • Allow blocking updating git tags via the API
  • Allow to force the creation of a git tag
  • Attempt to make the tests pass with markdown 3.2.1
  • Attempt to get this working with older pygit2
  • Handle attempts to create an existing git tag

1 new commit added

  • Add debugging

1 new commit added

  • Attempt to make it work

Finally \ó/

I'm going to clean up a bit the commit list and this should be ready to review :)

rebased onto 570c122dc569fa15788280f2c1810d3862db36b8

pretty please pagure-ci rebuild

:thumbsup:

Thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.