#4814 Improve the graphs of the stats tab
Merged by pingou. Opened by pingou.
better_stats_graph  into  master

Download 4814.patch

Fixes https://pagure.io/pagure/issue/4801

Here are some screenshots

Screenshot_from_2020-04-15_21-31-39.png
Screenshot_from_2020-04-15_21-31-54.png

Welp...

15:43:06  Failed tests:
15:43:06  FAILED test: py3-test_pagure_flask_api_issue

rebased onto 72993d8837a4be3405891b60ee918abec4462543

Would it be possible to add a 3rd item on the tickets: 'total open' ie, the number of open tickets at the start of the week? this would allow you to see easier if backlog was increasing or declining over time.

@kevin I think this was the original idea of this graph but doesn't quite work as expected, I may have an idea though, let's see if that'll work :)

@kevin how does this look?

Screenshot_from_2020-04-16_21-02-14.png

(these are the pagure issues, I'm working on the infra ones to see if they work as well)

Wow, that looks great! : D

@kevin how does this look?
Screenshot_from_2020-04-16_21-02-14.png

Looks great

This looks fantastic!

:thumbsup:

Awesome! The only nitpick I might have is that I am not sure blue and pink are good colors to use here... not sure what is tho...

great work!

It's actually blue and red, but the alpha layer make the red pinkish yeah :)

I'll see if I can make it a little darker to increase the contrast

4 new commits added

  • Add unit-tests for the detailed view of the issue stats
  • Adjust the red color in the stats graph to increase the contrast
  • Add a new chart tracking the number of open issues throughout the year
  • Rework the detailed provided for the issue stats

Now with unit-tests for the change to the API endpoint.

I've tweaked a little bit the color, but I doubt it's ideal yet, though I figure we can always tweak it more later :)

I don't fully understand this apidoc. Whitout detailed returns info for that week but with detailed for the last 53 weeks? Seems like a c&p glitch :)

It always returns the last 53 weeks, the detailed view as just more info than the non-detailed view.
Tbh, if it was me I'd make the default view be the detailed one, but that would be breaking API so no-go :(

Maybe it would make sense to have a new API endpoint for this, so we can simply remove the old one at some point in the future.

this could be _be instead of callling jquery's selector again? _b already has #commiter-list block from line 155

we were using the d3's minimized version, but now we include Chart.js's non minimized one. Should we import the minimized one?

does the heatmap thing depend on d3.v4.min.jis that this pr removes? (did not test it) or it conitnues working after this?

fair :thumbsup:

We have both version for chartjs, we can use the minimized one sure

6 new commits added

  • Add unit-tests for the detailed view of the issue stats
  • Adjust the red color in the stats graph to increase the contrast
  • Add a new chart tracking the number of open issues throughout the year
  • Rework the detailed provided for the issue stats
  • Improve the graph displayed in the stats tab of each projects
  • Add an option to retrieve detailed stats about issues in the API

:thumbsup:

:thumbsup:

rebased onto 11a9d5b05800cf866e71636269feb33a585b27b3

rebased onto 1b3a28eb00248bbb6f68da53a6b76b5ff2239d2b

rebased onto 4f0011e79526c5056b14eb17c2d3ab9184335bcf

lgtm once Jenkins is happy

Jenkins is happy, I'm happy people like the screenshots.

So let's get this in!

Pull-Request has been merged by pingou

Metadata