#4826 Fix sorting users by their username in python3 and introduce a new requirement on email_validator
Merged by pingou. Opened by pingou.
fix_sorted_py3  into  master

Download 4826.patch
no initial comment

2 new commits added

  • Fix sorting users by their username when using python3
  • The latest version of wtforms requires email_validator for our use of it

2 new commits added

  • Fix sorting users by their username when using python3
  • The latest version of wtforms requires email_validator for our use of it

rebased onto 5ce6dd00aa57955ad1d2f9ff6a3b58727508bf31

pip container:

======================================================================
FAIL: test_flag_commit_missing_status (tests.test_pagure_flask_api_project.PagureFlaskApiProjectFlagtests): Test flagging a commit with missing precentage.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/pagure/tests/test_pagure_flask_api_project.py", line 2864, in test_flag_commit_missing_status
    self.assertEqual(data, expected_output)
AssertionError: {'err[62 chars]INVALIDREQ', 'errors': {'status': ['This field is required.']}} != {'err[62 chars]INVALIDREQ', 'errors': {'status': ['This field is required']}}
  {'error': 'Invalid or incomplete input submitted',
   'error_code': 'EINVALIDREQ',
-  'errors': {'status': ['This field is required.']}}
?                                               -
+  'errors': {'status': ['This field is required']}}
-------------------- >> begin captured logging << --------------------
pagure.utils: INFO: logging already setup
--------------------- >> end captured logging << ---------------------
======================================================================
FAIL: test_api_modify_acls_neither_user_nor_group (tests.test_pagure_flask_api_project.PagureFlaskApiProjectModifyAclTests): Test the api_modify_acls method of the flask api when neither
        user nor group was set
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/pagure/tests/test_pagure_flask_api_project.py", line 3428, in test_api_modify_acls_neither_user_nor_group
    self.assertEqual(data, expected_output)
AssertionError: {'err[102 chars]his field is required.'], 'name': ['This field is required.']}} != {'err[102 chars]his field is required'], 'name': ['This field is required.']}}
  {'error': 'Invalid or incomplete input submitted',
   'error_code': 'EINVALIDREQ',
   'errors': {'name': ['This field is required.'],
-             'user_type': ['This field is required.']}}
?                                                  -
+             'user_type': ['This field is required']}}
-------------------- >> begin captured logging << --------------------
pagure.utils: INFO: logging already setup
--------------------- >> end captured logging << ---------------------
----------------------------------------------------------------------

rebased onto 59e0717efe1cec63f4389123058e5e13469ab753

Only a style test failure:

07:54:33  Failed tests:
07:54:33  FAILED test: py3-test_style

rebased onto f1444a4fd3e46e129becd9cd31047dcd54f61ad9

:thumbsup:

Pull-Request has been merged by pingou

Metadata