#4847 Add url_path property to class User.
Merged by pingou. Opened by xyzzyx.
xyzzyx/pagure master  into  master

Download 4847.patch

Add url_path @property to the class User in order to make it consistent with class Project that already has that property.

I like the idea, but you'll have to adjust a good number of tests before this passes CI :)

rebased onto 49543eae00f60951b018404a65f448cdce29d020

@xyzzyx This looks good, but could you please rebase this on upstream master to eliminate the merge commits? :smile:

rebased onto fdcad2b411ffd5117524530e544c2ec8635be187

:thumbsup:

I like this change but could you move it to its own commit?

One small comment and let's get this in :)

(Could you rebase while you adjust the commit? Otherwise I'll do it via the UI)

I like this change but could you move it to its own commit?

Same merge request or should I open a new one?

Same MR is fine for me, I consider the unit of change to be the commit more than the MR (thus the rebase and fast-forward merges)

rebased onto 936ebbea0f720fd2827e5663b6606f3be420b080

:thumbsup:

Thanks! :)

Pull-Request has been merged by pingou

Metadata