#491 Show list of commits from a particular commit hex
Closed by sayanchowdhury. Opened by sayanchowdhury.
sayanchowdhury/pagure rev-commits  into  master

Download 491.patch
no initial comment

Should we add some unit-tests for these changes?

Should we add some unit-tests for these changes?

Yes, This might require some test changes. I am currently looking into it.

Can you review the code to check to everything fine and I did not miss anything?

not repo_obj.is_empty

This is already checked above no?

The rest looks fine, I'll test it locally but from a quick look it looks fine :)

@sayanchowdhury, any luck with the unit tests here?

I'll will working on this tomorrow. There were some test cases which were failing

Closing this issue and will create a new one. Rebasing seems to be resulting in lot of conflicts.

Metadata