#4914 Allow a theme or a blueprint to inject custom buttons in the navigation bar.
Merged by pingou. Opened by xyzzyx.
xyzzyx/pagure master  into  master

Download 4914.patch
no initial comment

Is there an error with my patch or with jenkins? I only see this error in the output:

15:37:42  Error: Failed to download metadata for repo 'updates': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

@xyzzyx The datacenter move is making things wobbly, unfortunately...

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild

This should be the same length as the line above

Is this something we could test? I'm not sure if we have tests for other pieces of the theming though

rebased onto 751b20f586365c41f2dd55e2290667db392dbe3b

@xyzzyx Do you have a picture showing what this does?

It's a simple jinja {% block %} that allows to add custom content to the navbar.

Is this something we could test? I'm not sure if we have tests for other pieces of the theming though

I'd love to have an answer to this question before merging this PR :)

rebased onto 321b97deb20a480870a0dc71ae600ae176f3f27d

I'm not personally aware of any tests for UI components. On the other hand there isn't much to test here, it's just a jinja macro. If you copy the macro from doc/usage/theming.rst to something like pagure/themes/default/templates/theme.html you should see the effects on the pagure manu bar. What kind of tests are you interested in? Pagure defines some macro that can be used to customize the UI, for example head_imports() and footer(); this is just one more macro.

Is there a test for the footer() macro?

As far as I know, there isn't a test for the footer() macro either...

:thumbsup:

As far as I know, there isn't a test for the footer() macro either...

This was a good occasion to maybe start adding some :)

Pull-Request has been merged by pingou

Metadata