pagure

#4933 Setup the loggers in the git hooks and improve the example in the documentation on logging to a file
Merged by pingou. Opened by pingou.
setup_logs  into  master

Download 4933.patch
no initial comment

+1 looks good to me

pretty please pagure-ci rebuild

CI failed with what looks like a timeout so I kicked it off again

:thumbsup:

No the error is legit and jenkins will fail again.

Basically, we're expected a set string in the html but it returns us that string + the content of stdout when the pr failed to merge, which now includes all the content that was logged by the loggers to stdout (which is the default place where loggers log).
I think I'll need to adjust the loggers' config in these tests so they log to WARN which should shut them up.

2 new commits added

  • Adjust the example configuration for logging to a file
  • Set up the loggers in the hooks

rebased onto 53b3d839e8e0e63b0bcbdef025b73eb539140018

:thumbsup:

rebased onto 2686492bfce69ec9a47e500c5433130d5d0f18d1

+1

Thanks for the review folks :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.