Fixed forms' glitches - Remove <span class="errors">*</span> from forms.py and login_forms.py - Add <span class="errors">*</span> to templates/_formhelper.html
<span class="errors">*</span>
I like the idea and the change, though I suspect a few tests need to be adjusted for this :)
rebased onto 4fcf88e9b286d2143566f2cb22a90468196d79e9
Yes, I also agree to have tests, but my instance is running without problem as of now.
Looks like there are three tests failing:
tests/test_pagure_flask_ui_groups.py:201: AssertionError tests/test_pagure_flask_ui_app.py:2649: AssertionError tests/test_style.py:105: AssertionError
There is another one at tests/test_pagure_flask_ui_login.py:1136: but that seems weird
tests/test_pagure_flask_ui_login.py:1136:
I ran python -m black -l 79 --check --diff --exclude "/(\.eggs|\.git|\.hg|\.mypy_cache|\.nox|\.tox|\.venv|_build|buck-out|build|dist)/" ../pagure tests manually, then got
python -m black -l 79 --check --diff --exclude "/(\.eggs|\.git|\.hg|\.mypy_cache|\.nox|\.tox|\.venv|_build|buck-out|build|dist)/" ../pagure tests
would reformat ../pagure/runserver.py Oh no! 💥 💔 💥 91 files would be reformatted, 340 files would be left unchanged.
It seems many files hit.
rebased onto 8cc752c554219140bbc0a33508432f6e26b49cd5
Check the version of black you're using, we're still using black == 19.10b0; only
black == 19.10b0;
I also run black simply using black -l 79 tests/test_*.py pagure
black -l 79 tests/test_*.py pagure
Also, please use git rebase instead of git merge, we try to keep the history linear and avoid merge commits as much as possible :)
git rebase
git merge
I ran black -l 79 tests/test_*.py pagure, then I got:
pagure@lb:~/pagure$ black -l 79 tests/test_*.py pagure reformatted /srv/pagure/pagure/pagure/hooks/irc.py reformatted /srv/pagure/pagure/pagure/forms.py reformatted /srv/pagure/pagure/pagure/login_forms.py All done! ✨ 🍰 ✨ 3 files reformatted, 194 files left unchanged.
with no error.
Did you delete your fork?
Yes. please close this PR.
Pull-Request has been closed by mzch
Fixed forms' glitches
- Remove
<span class="errors">*</span>from forms.py and login_forms.py- Add
<span class="errors">*</span>to templates/_formhelper.html