PR#5020: Pagure-messages integration -

pagure

#5020 Pagure-messages integration

Merged Dec 5, 2020 by pingou. Opened Oct 27, 2020 by pingou.

pagure_messages into master

Download 5020.patch

no initial comment

pingou commented Oct 27, 2020

We're not fully there yet but I wanted to see what the tests look like at this point :)

1 new commit added

Fix test

Oct 27, 2020

1 new commit added

Install pagure-messages via pip for now

Oct 27, 2020

8 new commits added

Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 27, 2020

pretty please pagure-ci rebuild

Oct 27, 2020

1 new commit added

Looks like the bug is not gone in jenkins

Oct 28, 2020

9 new commits added

Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 28, 2020

ngompa commented Oct 29, 2020

Do we really need this to be mandatory when we conditionally import it only if fedora-messaging is used?

pingou commented Oct 29, 2020

You're right, it shouldn't be there. I'd add it to the requirements-test-txt though as I think we do want to check that in the tests we're sending the notifications we expect in the format we expect.

ngompa commented Oct 29, 2020

Sounds good to me.

rebased onto e47eb8d8d556ebf66eaaef1a37394f2eefb09010

Oct 29, 2020

10 new commits added

Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 29, 2020

pretty please pagure-ci rebuild

Oct 29, 2020

1 new commit added

Install fedora-messaging as RPM

Oct 29, 2020

1 new commit added

More debugging failing tests

Oct 30, 2020

12 new commits added

More debugging failing tests
Install fedora-messaging as RPM
Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 30, 2020

12 new commits added

More debugging failing tests
Install fedora-messaging as RPM
Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 30, 2020

12 new commits added

More debugging failing tests
Install fedora-messaging as RPM
Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 30, 2020

12 new commits added

More debugging failing tests
Install fedora-messaging as RPM
Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 30, 2020

12 new commits added

More debugging failing tests
Install fedora-messaging as RPM
Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 30, 2020

12 new commits added

More debugging failing tests
Install fedora-messaging as RPM
Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 30, 2020

12 new commits added

More debugging failing tests
Install fedora-messaging as RPM
Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 30, 2020

12 new commits added

More debugging failing tests
Install fedora-messaging as RPM
Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 30, 2020

1 new commit added

Specify the USER environment variable

Oct 30, 2020

pretty please pagure-ci rebuild

Oct 30, 2020

13 new commits added

Specify the USER environment variable
More debugging failing tests
Install fedora-messaging as RPM
Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Oct 30, 2020

1 new commit added

Ignore the generate_gitolite_acls task

Nov 2, 2020

14 new commits added

Ignore the generate_gitolite_acls task and use the pagure auth backend
Specify the USER environment variable
More debugging failing tests
Install fedora-messaging as RPM
Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Nov 2, 2020

2 new commits added

When checking if messages were sent via a rebase, do not run the git hooks
Add a NOGITHOOKS configuration key

Nov 2, 2020

17 new commits added

Forward the username when updating the pull-request
When checking if messages were sent via a rebase, do not run the git hooks
Add a NOGITHOOKS configuration key
Ignore the generate_gitolite_acls task and use the pagure auth backend
Specify the USER environment variable
More debugging failing tests
Install fedora-messaging as RPM
Attempt to debug/fix the tests
Looks like the bug is not gone in jenkins
Install pagure-messages via pip for now
Fix test
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Nov 2, 2020

10 new commits added

When checking if messages were sent via a rebase, do not run the git hooks
Add a NOGITHOOKS configuration key
Install fedora-messaging as RPM
Install pagure-messages via pip for now
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Nov 2, 2020

9 new commits added

When checking if messages were sent via a rebase, do not run the git hooks
Add a NOGITHOOKS configuration key
Install pagure-messages via pip for now but fedora-messaging as RPM
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Nov 2, 2020

1 new commit added

Upgrade pip/setuptools manually

Nov 2, 2020

10 new commits added

Upgrade pip/setuptools manually
When checking if messages were sent via a rebase, do not run the git hooks
Add a NOGITHOOKS configuration key
Install pagure-messages via pip for now but fedora-messaging as RPM
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Nov 2, 2020

10 new commits added

Upgrade pip/setuptools manually
When checking if messages were sent via a rebase, do not run the git hooks
Add a NOGITHOOKS configuration key
Install pagure-messages via pip for now but fedora-messaging as RPM
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Nov 3, 2020

9 new commits added

When checking if messages were sent via a rebase, do not run the git hooks
Add a NOGITHOOKS configuration key
Install pagure-messages via pip for now but fedora-messaging as RPM
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Nov 3, 2020

rebased onto 66012a9a45d63cca1d75485d63bc8c2dff84e0f4

Nov 5, 2020

rebased onto cf1da968e39fe8d9727137e7ed805adb079574df

Nov 17, 2020

rebased onto a4866a315fe96b0d89627c85c72ea65ab55e937f

Nov 18, 2020

pretty please pagure-ci rebuild

Nov 18, 2020

pretty please pagure-ci rebuild

Nov 18, 2020

pretty please pagure-ci rebuild

Nov 18, 2020

rebased onto dff4b540df3b7f7f2425507d37c86505abb40c38

Nov 18, 2020

pretty please pagure-ci rebuild

Nov 19, 2020

2 new commits added

Fix the test now that when we flag PR we're actually doing commit and PR flags
Fix the topic of the notification sent

Nov 19, 2020

11 new commits added

Fix the test now that when we flag PR we're actually doing commit and PR flags
Fix the topic of the notification sent
When checking if messages were sent via a rebase, do not run the git hooks
Add a NOGITHOOKS configuration key
Install pagure-messages via pip for now but fedora-messaging as RPM
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Nov 19, 2020

11 new commits added

Fix the test now that when we flag PR we're actually doing commit and PR flags
Fix the topic of the notification sent
When checking if messages were sent via a rebase, do not run the git hooks
Add a NOGITHOOKS configuration key
Install pagure-messages via pip for now but fedora-messaging as RPM
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Nov 19, 2020

11 new commits added

Fix the test now that when we flag PR we're actually doing commit and PR flags
Fix the topic of the notification sent
When checking if messages were sent via a rebase, do not run the git hooks
Add a NOGITHOOKS configuration key
Install pagure-messages via pip for now but fedora-messaging as RPM
Test the fedora-messaging notifications sent in the test suite
Add a notification for when a group is removed from a project
Be consistent about the name of the pull-request object and topics
Commit to the database earlier in the process so the JSON sent is up to date
Sort a number of lists returned in the API
Add support for pagure-messages

Nov 19, 2020

rebased onto 1c1a43a94ae5f1a0643d6915b497d27930a710dc

Nov 20, 2020

rebased onto 3c2e6d1b9d1c780971d821475c3a8bb701e2c0cd

Nov 22, 2020

pretty please pagure-ci rebuild

Nov 22, 2020

pretty please pagure-ci rebuild

Nov 22, 2020

pretty please pagure-ci rebuild

Nov 22, 2020

rebased onto d86de99433dd588949ccf423d690744425af897b

Nov 25, 2020

pretty please pagure-ci rebuild

Nov 25, 2020

rebased onto 2d735bf96d8fddfe6321ecb2e015245bb354e2bb

Nov 26, 2020

pingou commented Nov 27, 2020

This is ready for review I believe :)

rebased onto e9529d71aed77a3fe7dbddde64148ad27583b1f8

Nov 27, 2020

ngompa commented Nov 27, 2020

I'm still waiting for someone to do a package review for https://bugzilla.redhat.com/show_bug.cgi?id=1899298

ngompa commented Dec 1, 2020

Packages submitted to Bodhi:

F33: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b2d9ed864e
F32: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9afa1d1530
EPEL8: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-4a81277172

rebased onto b7b9b08ede8ef21098dc46d2012a1e6c9f86b7fe

Dec 2, 2020

rebased onto 8c514db1661b5e261cd8a972dc5cbc3aee5f9333

Dec 2, 2020

rebased onto b411ed5758f5e0aa09d11d1d6140d77a0b18153a

Dec 4, 2020

rebased onto f70c0a49c8c882cd036ab8523267a37b58ca46e8

Dec 4, 2020

wwoods commented Dec 5, 2020

I don't know the API / internals well enough to understand how 520a161 works but everything else makes sense and looks good to me. +1!

pingou commented Dec 5, 2020

I don't know the API / internals well enough to understand how 520a161 works but everything else makes sense and looks good to me. +1!

Without this the topic sent was of the type "org.pagure.prod.Flag .flag.updated" or so, removing the "Flag " earlier on allowed for a more expected topic format :)

Thanks for the review!!

Pull-Request has been merged by pingou

Dec 5, 2020

Metadata

Assignee

None

Tags

No Tags

pagure

#5020 Pagure-messages integration Merged Dec 5, 2020 by pingou. Opened Oct 27, 2020 by pingou. pagure_messages into master

Metadata

#5020 Pagure-messages integration

Merged Dec 5, 2020 by pingou. Opened Oct 27, 2020 by pingou.

pagure_messages into master