This is not quite ready to be merged as it breaks the python 2 support, however, it looks like the event source server no longer works on python3, so if you are running pagure with python3 could can download and use this code instead of the one being shipped in the tarball until this PR gets merged.

Fails on centos7/py2 (obviously...)

hit this on F37

for python 3.11 we also need https://src.fedoraproject.org/fork/thrnciar/rpms/python-aiohttp-cors/blob/2dd0df4b61e23c32617cc97985696904c1f1fd6a/f/1eb2226aaf664d0be746753a32f82ee2e04c2f0b.patch

@pingou are we in an okay place to land this?

I'm testing this on my pagure instance on my laptop
and I need remove @asyncio.coroutine decorator https://pagure.io/fork/sergiomb/pagure/c/70a6822ec2bd3913630c93d2e09ad6a1b524421c

@pingou are we in an okay place to land this?

I'd say we probably want another 5.x version before we start on 6.x, so I'd wait
a little longer if we can bear it

I'd say we probably want another 5.x version before we start on 6.x

I created an Issue to discuss and perform the necessary preparation to work on those releases in a coordinated way: https://pagure.io/pagure/issue/5370

The master branch already has Python 2 support ripped out, so if we're making another 5.x release, we'll need to craft a branch for it at the point before I did that and cherry-pick things.

The master branch already has Python 2 support ripped out, so if we're making another 5.x release, we'll need to craft a branch for it at the point before I did that and cherry-pick things.

I checked the merged PR's and couldn't find something related to active removal of Python 2 from the master branch. But yeah, no tests are running against py2 right now so probably things are at least broken somehow.

I'm open for both options (another 5.x release or jumping direct to 6.0), I think most important is that we are aligned what we want to do and try to coordinate the necessary tasks.

Reminder from @sergiomb (https://pagure.io/pagure/issue/5370#comment-836797) that remove @asyncio.coroutine decorator need to be included in this PR, @pingou independent of the "when to merge into master" discussion, could you include those changes?

I'm not sure that change is correct, because that eliminates the async nature of those methods entirely. The code needs to be adapted to the async/await syntax instead.

I'm not sure that change is correct, because that eliminates the async nature of those methods entirely. The code needs to be adapted to the async/await syntax instead.

yeah, I didn't a pull request because I also don't know if it is the best fix

I can't put async def as suggest , because gives error on startup

https://src.fedoraproject.org/fork/thrnciar/rpms/python-aiohttp-cors/blob/2dd0df4b61e23c32617cc97985696904c1f1fd6a/f/1eb2226aaf664d0be746753a32f82ee2e04c2f0b.patch

Closing in favour of https://pagure.io/pagure/pull-request/5463, dropping trololio is part of it.