pagure

#5056 Fix API project options/update
Merged by pingou. Opened by bmwiedemann.
bmwiedemann/pagure api-project  into  master

Download 5056.patch

Without this patch, setting values to false was ignored:
https://gist.github.com/bmwiedemann/9f41fe53ee004c815cf21c17e89e266c

:thumbsup:

aouch!

Many many thanks for tracking and finding this, I will not run git blame on this line of code by fear of seeing who made that accident...

If jenkins agrees, I'll merge this :)

Was from commit 473ccbe93 - always happy to help :-P

For the record, I'm not clicking on that link :D

2 new commits added

  • api/project: Extend test coverage
  • api/project: Fix handling of "false"

:thumbsup:

Something is still not right. I cannot even set values to true

Is the "Modify an existing project" API-token ACL the right one?

Am I doing something wrong in the script (see gist linked above)?

Is the "Modify an existing project" API-token ACL the right one?

Yes: https://pagure.io/pagure/blob/3c528059761a2e6d7133b2d576ea04d31eae86f8/f/pagure/api/project.py#_2843

Am I doing something wrong in the script (see gist linked above)?

Do you have the full output returned by pagure? The JSON should have some clues.

rebased onto 457dbd17a30833676afdc65a03a6946d9a729c76

I was able to reproduce the issue locally and the answer is: that API endpoint did not accept JSON input, so you either have to provide the different argument as HTML arguments, or wait for the incoming PR :)

Cf PR #5058

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.