pagure

#5094 Improve cchardet integration and support python-chardet 4.0+
Merged by pingou. Opened by pingou.
chardet4  into  master

Download 5094.patch
no initial comment

Provided tests pass... :thumbsup:

rebased onto e8f564fe0a49d1e46acaae44a138829ba774aba5

pretty please pagure-ci rebuild

rebased onto 1f1bc958a8ced8403cf8f98a4d8699adbd0fbb3d

rebased onto f2df67cb8a563a70895269977e4ed92e545d2da0

2 new commits added

  • Improve cchardet integration
  • Port pagure to chardet 4.0+

2 new commits added

  • Improve cchardet integration
  • Port pagure to chardet 4.0+

@pingou why are we falling back to ascii instead of utf-8? I thought we deliberately changed to utf-8?

@pingou why are we falling back to ascii instead of utf-8? I thought we deliberately changed to utf-8?

We fixed the integration with cchardet, I think what we add until now was actually broken (wrong API used apparently).
Now both chardet and cchardet return consistent result for these files (ascii)

:thumbsup:

Thanks!

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.