From b2a6635e41fb7a267796d922813c6e8793f23164 Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Jan 19 2021 21:57:50 +0000
Subject: Do not return a 500 error when the OpenID provider doesn't provide an email


Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

---

diff --git a/pagure/ui/fas_login.py b/pagure/ui/fas_login.py
index b7b6732..4689fd1 100644
--- a/pagure/ui/fas_login.py
+++ b/pagure/ui/fas_login.py
@@ -49,6 +49,15 @@ def set_user(return_url):
     if not user:
         flask.session["_new_user"] = True
     else:
+        if not flask.g.fas_user.email:
+            flask.flash(
+                "No email address was returned by your OpenID provider, this "
+                "information is mandatory for pagure",
+                "error",
+            )
+            logout()
+            return flask.redirect(return_url)
+
         user_email = pagure.lib.query.search_user(
             flask.g.session, email=flask.g.fas_user.email
         )