pagure

#5112 Fix broken pagination of group API
Merged by pingou. Opened by lbrabec.
lbrabec/pagure fix/group_pagination  into  master

Download 5112.patch

Fix for #5111

:thumbsup:

Should we look at the tests for this?

1 new commit added

  • Add basic pagination test for group API

1 new commit added

  • Add basic pagination test for group API

@pingou I've added a basic test for this. It fails without the fix applied, passes with the fix. Can you take a look? It might be enough of a test imo as it's currently broken, but it's up to you ofc :)

Should we do a first assert here? It'll highlight the difference between page 1 and 2

2 new commits added

  • Add basic pagination test for group API
  • Fix broken pagination of group API

Should we do a first assert here? It'll highlight the difference between page 1 and 2

Done, I've left the complete assert in the end too, I can change that if you want?

Looks good to me!

1 new commit added

  • Code styling issue fix around group api pagination fix

The tests passed, the el7 failure is un-related to this PR so let's get this in :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.