PR#519: Add support to edit comment of an issue and clean the code a little to make it more generic -

pagure

#519 Add support to edit comment of an issue and clean the code a little to make it more generic

Merged Dec 3, 2015 by pingou. Opened Dec 3, 2015 by pingou.

edit_issue_comment into editing

no initial comment

pingou commented Dec 3, 2015

Fixes https://pagure.io/pagure/issue/484

puiterwijk commented Dec 3, 2015

Just wondering, but would it be an idea to put both of these in a single migration, since there has not been a Pagure release that had the previous one, and these two changes are very close together?

pingou commented Dec 3, 2015

We could be it kind of also make sense to keep them separate, also because there were two people working on them

puiterwijk commented Dec 3, 2015

Would it be an idea to instead of defaulting to issue and then have a fallback to pull-request, default to "unknown", and have specific cases for pull-request and issue?
That would be a bit more robust if we add more things (as it would fail to "unknown" instead of "issue", making for easier debugging), and is more symmetrical.

pingou commented Dec 3, 2015

wfm

puiterwijk commented Dec 3, 2015

Fair enough, just throwing out the idea.

puiterwijk commented Dec 3, 2015

I personally like the url_for usage as it would work with other mount paths.

puiterwijk commented Dec 3, 2015

This would complicate this quite a bit. Ignore previous comment.

puiterwijk commented Dec 3, 2015

This would complicate this quite a bit. Ignore previous comment.

puiterwijk commented Dec 3, 2015

Looks good to me.