From cae4739f16033504e1fa7e218ba46351bbdc5ab9 Mon Sep 17 00:00:00 2001
From: L. Guruprasad <lgp171188@gmail.com>
Date: Apr 19 2024 21:59:16 +0000
Subject: [PATCH 1/3] Fix the breadcrumb styles for the file history page


---

diff --git a/pagure/templates/file_history.html b/pagure/templates/file_history.html
index d2503b0..76830f7 100644
--- a/pagure/templates/file_history.html
+++ b/pagure/templates/file_history.html
@@ -63,7 +63,7 @@
     <div class="card">
       <div class="card-header">
         <ol class="breadcrumb p-0 bg-transparent mb-0">
-          <li>
+          <li class="breadcrumb-item">
             <a href="{{ url_for('ui_ns.view_tree',
                 repo=repo.name,
                 username=username,
@@ -81,7 +81,7 @@
           {% else %}
           {% set path = path + '/' + file %}
           {% endif %}
-          {% if loop.index != loop.length %}<li><a
+          {% if loop.index != loop.length %}<li class="breadcrumb-item"><a
           href="{{ url_for('ui_ns.view_file',
                 repo=repo.name,
                 username=username,
@@ -91,7 +91,7 @@
             <span class="fa fa-folder"></span>&nbsp; {{ file }}</a>
           </li>
           {% elif file %}
-          <li class="active">
+          <li class="breadcrumb-item active">
             <span class="fa {% if output_type == 'tree' %}fa-folder{% else %}fa-file{% endif %}">
             </span>&nbsp; {{ file }}
           </li>

From d984f0c159d988bd6bdb97cf4b8b1da5c5db4129 Mon Sep 17 00:00:00 2001
From: L. Guruprasad <lgp171188@gmail.com>
Date: Apr 19 2024 21:59:16 +0000
Subject: [PATCH 2/3] Fix the broken breadcrumb path in the file history page


---

diff --git a/pagure/templates/file_history.html b/pagure/templates/file_history.html
index 76830f7..1b74ac8 100644
--- a/pagure/templates/file_history.html
+++ b/pagure/templates/file_history.html
@@ -74,13 +74,8 @@
               </span>&nbsp; {{ branchname }}
             </a>
           </li>
-        {% set path = '' %}
         {% for file in filename.split('/') %}
-          {% if loop.first %}
-          {% set path = file %}
-          {% else %}
-          {% set path = path + '/' + file %}
-          {% endif %}
+          {% set path = '/'.join(filename.split('/')[:loop.index]) %}
           {% if loop.index != loop.length %}<li class="breadcrumb-item"><a
           href="{{ url_for('ui_ns.view_file',
                 repo=repo.name,

From 311fb7b257fb226eae54b701e55cf3db53ed9f69 Mon Sep 17 00:00:00 2001
From: L. Guruprasad <lgp171188@gmail.com>
Date: Apr 19 2024 21:59:16 +0000
Subject: [PATCH 3/3] Link to the file in the file history page breadcrumb


Also simplify the breadcrumb generation code since the output_type is
hard-coded to "history".

Fixes https://pagure.io/pagure/issue/4793

---

diff --git a/pagure/templates/file_history.html b/pagure/templates/file_history.html
index 1b74ac8..8b2af2b 100644
--- a/pagure/templates/file_history.html
+++ b/pagure/templates/file_history.html
@@ -76,21 +76,20 @@
           </li>
         {% for file in filename.split('/') %}
           {% set path = '/'.join(filename.split('/')[:loop.index]) %}
-          {% if loop.index != loop.length %}<li class="breadcrumb-item"><a
-          href="{{ url_for('ui_ns.view_file',
+          {% if loop.last %}
+          {% set path_type = 'file' %}
+          {% else %}
+          {% set path_type = 'folder' %}
+          {% endif %}
+          <li class="breadcrumb-item">
+            <a href="{{ url_for('ui_ns.view_file',
                 repo=repo.name,
                 username=username,
                 namespace=repo.namespace,
                 identifier=branchname,
                 filename=path | unicode)}}">
-            <span class="fa fa-folder"></span>&nbsp; {{ file }}</a>
+            <span class="fa fa-{{ path_type }}"></span>&nbsp; {{ file }}</a>
           </li>
-          {% elif file %}
-          <li class="breadcrumb-item active">
-            <span class="fa {% if output_type == 'tree' %}fa-folder{% else %}fa-file{% endif %}">
-            </span>&nbsp; {{ file }}
-          </li>
-          {% endif %}
         {% endfor %}
         </ol>
       </div>