pagure

#5206 Fix PR close in API for user token
Merged by pingou. Opened by zlopez.
zlopez/pagure close_pull_request  into  master

Download 5206.patch

Currently the close PR API call has some issues when called by using cross project token instead of project only token, this PR fix those issues.

This allows for cross-project API tokens with this ACL

:thumbsup: for me

Tests are passing on pagure-fedora-rpms-py3

1 new commit added

  • Allow PR author to close PR using API

2 new commits added

  • Allow PR author to close PR using API
  • Don't assume project token for PR close

:thumbsup: on the new commit

We should look at expanding the test suite for this though

I can look at the tests, but I have difficulties to run them locally, even in vagrant machine.
I tried the container test run, but I'm not sure what I did wrong. Should ./dev/run-tests-container.py --repo . --branch close_pull_request work for running the tests locally?

1 new commit added

  • Add test for cross-project API token

1 new commit added

  • Use the correct status_code in test

pretty please pagure-ci rebuild

rebased onto c3e5610f42fbbfa55c32cc3fb8e86b58479efea4

Could we merge this, it's only failing on CentOS Stream 8

I'm working to fix the CS8 target today, then I'll go through and re-run and merge things.

@ngompa Thanks

rebased onto 7c817feffb07b526df4f1f61cdb7984056a63541

rebased onto bbfd98c556ac6ed0f49a76dfafac004f217a220e

rebased onto 661557f3ecab5630e083ae498a54398ca3b5f007

Tests pass on fedora-rpms-py3 so I'm going to merge it :)

Pull-Request has been merged by pingou

Was this change deployed on staging yet? I tried to test it on dist-git today and it looks like it isn't.
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.