#521 Added missing count in search result and tweaks for switch button status.
Merged by pingou. Opened by aavrug.
aavrug/pagure master  into  master

Download 521.patch
no initial comment

So, it seems the PR isn't up to date with what's in master, could you rebase?

Also, why the removal of the and not hide bits?

Done the rebase.

After login in the user page on switching on any button, the related section comes up and on switching off it goes which is right but in home page It was just reversed. That's why I removed that to fix it.

Done the rebase.
After login in the user page on switching on any button, the related section comes up and on switching off it goes which is right but in home page It was just reversed. That's why I removed that to fix it.

Yes that's a valid issue.
The repos_switch macro takes in the value of default value of hide as True. You need to alter the macro call here by overriding the value of hide -
https://pagure.io/pagure/blob/master/f/pagure/templates/index.html#_26

Thanks sayanchowdhury.

This is not going to work for the case where we want the hide feature to work.

The boolean to toggle hide is only there to override the configuration on the user profile's page where we never want to hide a section by default.

Where is this needed?

Ok I see where it's needed, but I'm not seeing what doesn't work currently

Found it, cool, thanks for the fix :)

the count is not showing in between "()" in the search result.

I had forgot about the /projects/ endpoint.

Mind adding it to the list of blacklisted project names to the configuration file (and sample configuration file)?

Perfect, thanks!

Perfect, thanks!

Metadata