pagure

#5457 Owner of a PR can update is own PR
Merged by ngompa. Opened by mmassari.
mmassari/pagure pr_owner_can_update_it  into  master

Download 5457.patch

me again :)

I changed default ACLs for a user token.
I don't get the EINVALIDTOK anymore but now I get EPRNOTALLOWED.
This PR should allow Packit to finally edit its own PRs.

Packit needs this change to be able to update PRs
it has already created.
We are implementing this feature:
https://github.com/packit/packit/issues/2182

Related with commit 133da07764314a73452487603f6f509b05f96204

We realized that this change also affects api_pull_request_assign.
The PR owner will be now able to change the assignee.

Is it ok, or should I refactor it in a way that the two api calls api_pull_request_assign and api_pull_request_update use two different checks?

rebased onto 38b0100a4894de51963d57b132451b83596dc27e

We realized that this change also affects api_pull_request_assign.
The PR owner will be now able to change the assignee.

Is it ok, or should I refactor it in a way that the two api calls api_pull_request_assign and api_pull_request_update use two different checks?

@mmassari good catch, I see what you mean. I think the PR shouldn't change the current behavior. So I suggest to refactor so that api_pull_request_assign isn't affected.

Metadata Update from @wombelix:
- Request assigned

Ok, I will work on it and I will let you know when I am done.

rebased onto ab180764be9f5c9bc71355e82845b777e394a74f

rebased onto cc6bd0ee857691deec630a069a07857027d321aa

rebased onto 887fe0238e12952f9ec3a3eafc2084e01f63475d

rebased onto e1c1deaea4e2383c6b213247b24cc46e4d327b59

rebased onto 081884196058896b7354f9a658ad1ca9d5960007

3 new commits added

  • Allow author to update PR but not to change assignee
  • Owner of a PR can update is own PR
  • Owner of a PR can update is own PR

rebased onto 98c893c32ee148065faa832e0624a964db6e8bb0

rebased onto a3cd8f60bc7f7c8f29f1ce0f0737c2778bb839d2

Pull-Request has been merged by ngompa
Metadata
wombelix
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.