If this passes all the tests, can you squash this into a single commit? I don't think this needs to be split into 58 non-atomic changes.

OK I missed one black finding. The AssertionError: unexpectedly None errors can be ignored, those are issues that only happen in the CI. I'm pretty sure at some point we hit memory/cpu issues and a celery task get lost somehow. So I will later push a fix for the style issue.

If this passes all the tests, can you squash this into a single commit? I don't think this needs to be split into 58 non-atomic changes.

Sure, was more a pre-caution during carving that stuff out in case I need to dig up parts again :smile:

CI errors are all AssertionError: unexpectedly None which doesn't happy in local tests and will hopefully solved in the pipeline when https://pagure.io/pagure/issue/5466 is implemented.
I'm going to squash and push it as single commit as requested.
Last chance to do a review, especially of tests I dropped, those changes are the most risky.

This is gargantuan and well done, thanks! :thumbsup:

The tests look good too. If nobody has anything to say about it by midday PDT, I'll merge it.

This is now merged. Let's see how things go...