#592 Add support for markup file rendering in Tree browser
Merged by pingou. Opened by ymartin1040.
ymartin1040/pagure master  into  master

Download 592.patch
no initial comment

So one thing about this is that ?text=False will show the same result as ?text=True.

One solution for this is to do:

raw_text = flask.request.args.get('text')
if str(raw_text).lower() in ['0', 'false']:
    raw_text = False
...
elif ext in ('.rst', '.mk', '.md') and not raw_text:
    ...

OK. What is the procedure to fix a pending pull-request ? Should I discard it complete and submit a new one with a proper commit ?

Updating your branch should update this PR automatically, so no need to close/re-submit, you can either add a new commit or force push one to your fork.

Btw, while doing so, could you rebase it on the top of master?

Thanks!

So here it is.

ahah, I see your Java showing up here :) (in the variable names)

I'm going to merge this and maybe change a little the variable name from disableMarkup to raw (if you're ok with this).

Metadata